🐛 Fix confirm

boardgamers · Oct 22, 2024 · d5ed73a · d5ed73a
1 parent 62294ab
commit d5ed73a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/apps/api/app/models/user.ts b/apps/api/app/models/user.ts
@@ -247,9 +247,6 @@ schema.method("confirmKey", function (this: UserDocument) {
 });
 
 schema.method("confirm", function (this: UserDocument, key: string) {
-  if (this.security.confirmed) {
-    return;
-  }
   assert(key && this.confirmKey() === key, `Wrong confirm link.`);
   this.security.confirmed = true;
   this.security.confirmKey = null;

diff --git a/apps/api/app/routes/account/index.ts b/apps/api/app/routes/account/index.ts
@@ -259,8 +259,15 @@ router.post("/confirm", async (ctx: Context) => {
     throw createError(404, "Can't find user: " + ctx.request.body.email);
   }
 
+  if (user.security.confirmed) {
+    ctx.redirect("/login");
+    return;
+  }
+
   await user.confirm(ctx.request.body.key);
 
+  ctx.state.user = user;
+
   await sendAuthInfo(ctx);
 });
 

diff --git a/apps/web/src/routes/confirm.svelte b/apps/web/src/routes/confirm.svelte
@@ -6,6 +6,13 @@
   import type { LoadInput } from "@sveltejs/kit";
 
   export async function load(input: LoadInput) {
+    if (typeof window === "undefined") {
+      // Bug in node 20+, handle client-side
+      return {
+        status: 200,
+        body: {},
+      };
+    }
     const { post, setAuthData } = useLoad(input, useAccount, useRest);
     await post<AuthData>("/account/confirm", {
       key: input.url.searchParams.get("key"),