Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix payment check for testnet #623

Merged

Conversation

forcodedancing
Copy link
Contributor

@forcodedancing forcodedancing commented May 22, 2024

Description

This pr will update payment check to ignore some known issue on test (the issue only happened on testnet).

Rationale

Fix payment data check.

Example

NA

Changes

Notable changes:

  • update payment check logic

Potential Impacts

  • no impact to fullnodes/validators

unclezoro
unclezoro previously approved these changes May 22, 2024
alexgao001
alexgao001 previously approved these changes May 22, 2024
@forcodedancing forcodedancing dismissed stale reviews from alexgao001 and unclezoro via 7b672ca May 23, 2024 02:45
@unclezoro unclezoro added this pull request to the merge queue May 24, 2024
Merged via the queue into bnb-chain:develop with commit e418737 May 24, 2024
5 checks passed
forcodedancing added a commit to forcodedancing/greenfield that referenced this pull request May 24, 2024
* chore: fix payment check for testnet

* update price time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants