Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix uncharge issue when force-deleting objects #601

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

yutianwu
Copy link
Collaborator

@yutianwu yutianwu commented Apr 1, 2024

Description

This pr will remove MsgSetBucketFlowRateLimit from Serengeti upgrade and fix the issue when force-deleting buckets.

Rationale

Fix uncharge issue when force-deleting objects

Example

n/a

Changes

Notable changes:

  • remove MsgSetBucketFlowRateLimit from Serengeti upgrade
  • fix the issue when force-deleting buckets

Potential Impacts

n/a

@yutianwu yutianwu changed the title WIP: fix: fix uncharge issue when force-deleting objects fix: fix uncharge issue when force-deleting objects Apr 1, 2024
@forcodedancing
Copy link
Contributor

The e2e test failed.

app/upgrade.go Outdated Show resolved Hide resolved
KeefeL
KeefeL previously approved these changes Apr 2, 2024
app/upgrade.go Outdated Show resolved Hide resolved
@yutianwu yutianwu enabled auto-merge April 2, 2024 08:03
@yutianwu yutianwu added this pull request to the merge queue Apr 2, 2024
Merged via the queue into bnb-chain:master with commit 6868d14 Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants