fix: add sp exit status check when craete gvg #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynnss
changed the title
will-2012
approved these changes
Aug 21, 2023
alexgao001
reviewed
Aug 21, 2023
x/virtualgroup/keeper/msg_server.go
Outdated
| @@ -56,6 +56,10 @@ func (k msgServer) CreateGlobalVirtualGroup(goCtx context.Context, req *types.Ms | |||
| return nil, sptypes.ErrStorageProviderNotFound.Wrapf("The address must be operator address of sp.") | |||
| } | |||
|
|
|||
| if !sp.IsInService() { | |||
There was a problem hiding this comment.
should also allow Maintenance SP otherwise it is not able to conduct self test if no GVG created yet?
There was a problem hiding this comment.
Fixed. Does sp in maintenance can send swapout tx?
There was a problem hiding this comment.
yes, make sense. Please review this pr again. thx.
alexgao001
approved these changes
Aug 23, 2023
fynnss
added a commit
that referenced
this pull request
Aug 24, 2023
* add sp exit status check when create gvg and swapout * allow sp in maintenance can create gvg
KeefeL
pushed a commit
that referenced
this pull request
Aug 24, 2023
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sp exit status check when craete gvg
Rationale
Add sp exit status check when craete gvg
Example
NA
Changes
Notable changes: