New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sp maintenance mode #403

Merged

unclezoro merged 12 commits into bnb-chain:develop from alexgao001:sp_maintenance_mode

Aug 8, 2023

Collaborator

alexgao001 commented Aug 3, 2023 •

edited

Loading

Description

Currently When a external SP joins the network, it would need to start serving immediately, all other SPs would consider it is
ready and might choose it as a secondary SP to form GVG. User might also choose it to serve their request. But there is no way to guarantee everything works fine until the SP does a self testing to ensure it is fully prepared. This self testing includes:

Create bucket.
Create object.
Seal object.
Update ObjectInfo
Delete Object
Delete Bucket

After SP has done the test, it should send a tx to chain to activate itself.

If a SP is already in service and it wants to turn into Maintenance mode. It is also supported.

Note: The total maintenance period, frequency of updating status, and each requested maintenance period from SP should be restricted.

Rationale

enhance SP stability

Example

add an example CLI or API response...

Changes

Notable changes:

add each change in a bullet point here
...


          add maintenance mode for sp

a51e739

alexgao001 added the wip label

alexgao001 added 3 commits

August 3, 2023 18:54


          resolve conflict

6a509d7


          update cosmos sdk

ae09e93


          fix test

1723de1

alexgao001 force-pushed the sp_maintenance_mode branch from 618ed06 to 1723de1 Compare

August 3, 2023 12:28

fynnss reviewed

View reviewed changes

deployment/localup/create_sp.json Outdated Show resolved Hide resolved

x/sp/keeper/sp_maintenance.go Outdated Show resolved Hide resolved

alexgao001 added 4 commits

August 4, 2023 16:10


          add query api and fix test

8a7ebc6


          change underlying storage model

a1d0e15


          Merge branch 'develop' of github.com:bnb-chain/greenfield into sp_mai…

45ac7a8

…ntenance_mode


          add cmd

aadb1a5

alexgao001 force-pushed the sp_maintenance_mode branch from 8ac8996 to aadb1a5 Compare

August 5, 2023 12:13

unclezoro reviewed

View reviewed changes

proto/greenfield/sp/events.proto Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

proto/greenfield/sp/events.proto Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

proto/greenfield/sp/tx.proto Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

proto/greenfield/sp/tx.proto Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

proto/greenfield/sp/tx.proto Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

proto/greenfield/sp/types.proto Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/challenge/abci.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/challenge/keeper/msg_server_submit.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/client/cli/flags.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/msg_server.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/msg_server.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/msg_server.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/msg_server.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/msg_server.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/keeper/keeper.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/keeper/keeper.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/keeper/keeper.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/keeper/virtualgroup.go Outdated Show resolved Hide resolved

alexgao001 added 2 commits

August 8, 2023 12:13


          fix comments

e3a2e7b


          fix the renaming

b4b658a

unclezoro added r4r and removed wip labels

unclezoro reviewed

View reviewed changes

x/sp/keeper/sp_status.go

+              			if len(stats.Records) == 0 {
+              				store.Delete(key)
+              			} else {
+              				store.Set(key, k.cdc.MustMarshal(&stats))

Collaborator

unclezoro Aug 8, 2023

I think in most case, there is no need to set here, can we have an indicator to know whether we should set or not.

unclezoro approved these changes

View reviewed changes

alexgao001 added 2 commits

August 8, 2023 15:32


          only persist when there is change

a3f8621


          only persist when there is change

d8dbca4

unclezoro added this pull request to the merge queue

Merged via the queue into bnb-chain:develop with commit 3bec088

5 checks passed

This was referenced Aug 8, 2023

release: draft release for v0.2.4-alpha.1 #405

Merged

release: prepare release for 0.2.4-alpha.1 #406

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r4r