fix: add group existence check when verify permission #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynnss
force-pushed
the
develop
branch
2 times, most recently
from
5a0b405
to
132422a
Compare
fynnss
requested review from
yutianwu,
unclezoro,
forcodedancing and
BarryTong65
yutianwu
reviewed
Aug 3, 2023
yutianwu
reviewed
Aug 3, 2023
yutianwu
reviewed
Aug 4, 2023
BarryTong65
approved these changes
Aug 8, 2023
yutianwu
approved these changes
Aug 8, 2023
fynnss
force-pushed
the
develop
branch
3 times, most recently
from
9258f57
to
f7f532e
Compare
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add group existence check when verify permission
Rationale
Because the expired permission information is not deleted in time, the verification will success, but is expected to failed.
for more information, see stale permission clean in EndBlock. https://github.com/bnb-chain/greenfield/blob/master/x/storage/keeper/keeper.go#L1693-L1728
Example
NA
Changes
Notable changes: