feat: add new query APIs #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realuncle
reviewed
Jul 31, 2023
realuncle
reviewed
Jul 31, 2023
proto/greenfield/storage/query.proto
Outdated
| } | ||
|
|
||
| message QueryGroupMembersExistResponse { | ||
| repeated bool are_members = 1; |
There was a problem hiding this comment.
I think it is better not only boolean, but response the accordingly accounts as well.
realuncle
reviewed
Jul 31, 2023
proto/greenfield/storage/query.proto
Outdated
|
|
||
| message QueryGroupsExistRequest { | ||
| repeated string group_names = 1; | ||
| repeated string group_owners = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; |
There was a problem hiding this comment.
group_owners is not repeated I think
fynnss
reviewed
Jul 31, 2023
proto/greenfield/storage/query.proto
Outdated
|
|
||
| // Queries whether some groups are exist. | ||
| rpc QueryGroupsExist(QueryGroupsExistRequest) returns (QueryGroupsExistResponse) { | ||
| option (google.api.http).get = "/greenfield/storage/groups_exist/{group_names}/{group_owners}"; |
There was a problem hiding this comment.
- Query multiple groups under one user at once
- Query multiple groups under multiple users at once
Shall we use a more generic ways to support?
There was a problem hiding this comment.
To keep things simple, I think we'd better only support Query multiple groups under one user at once.
| repeated string group_ids = 1; | ||
| } | ||
|
|
||
| message QueryGroupsExistResponse { |
There was a problem hiding this comment.
Shall we unify the name of the API? E,g. HeadGroup, HeadGroups, HeadGroupById, HeadGroupsByIds, HeadGroupMember, HeanGroupMemebers
There was a problem hiding this comment.
The methods you mentioned are all existed. These new APIs are just used to query if the object exists
pythonberg1997
force-pushed
the
new_apis
branch
from
65f8f6c
to
cfc32de
Compare
unclezoro
approved these changes
Aug 1, 2023
pythonberg1997
force-pushed
the
new_apis
branch
from
3c38e1b
to
96bbaf3
Compare
fynnss
approved these changes
Aug 3, 2023
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add some new query APIs for group and group member.
Changes
Notable changes: