Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ACTION_UPDATE_OBJECT_INFO not allowed to be used on object's bug #285

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix: ACTION_UPDATE_OBJECT_INFO not allowed to be used on object's bug #285

merged 2 commits into from
Jun 26, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Jun 9, 2023 •
edited
Loading

Description

When executing the "updateobjectinfo" command to update bucket information, you may encounter the following error:
ACTION_UPDATE_OBJECT_INFO is not allowed to be used on an object.

Rationale

  • Fix go-cmd updateobjectinfo bug
    This check was used in ValidateBasic, The chain's e2e test doesn't use ValidateBasic.
  • fix a bug updateObjectEvent missing object id

Example

NA...

Changes

Notable changes:

  • NA
  • ...

@jingjunLi jingjunLi added the r4r label Jun 16, 2023
fynnss
fynnss approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@fynnss fynnss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, pls refine the PR description.

@jingjunLi
Copy link
Contributor Author

LGTM. BTW, pls refine the PR description.

I have updated the description of the PR as requested

@jingjunLi jingjunLi merged commit 0899864 into develop Jun 26, 2023
This was referenced Jun 26, 2023
Merged
Merged
randyahx pushed a commit to randyahx/greenfield-randyahx that referenced this pull request Jul 11, 2023
@jingjunLi @randyahx
fix: ACTION_UPDATE_OBJECT_INFO not allowed to be used on object's bug (…
77a8b88 
…bnb-chain#285)

(cherry picked from commit 0899864)
@randyahx randyahx mentioned this pull request Jul 11, 2023
Merged
keefel pushed a commit that referenced this pull request Jul 11, 2023
@randyahx @jingjunLi @alexgao001
fix: cherrypicked commits #285 #295 (#335)
e4146e0 
* fix: ACTION_UPDATE_OBJECT_INFO not allowed to be used on object's bug (#285)

(cherry picked from commit 0899864)

* add missing field to event (#295)

(cherry picked from commit 1948733)

---------

Co-authored-by: Chris Li <[email protected]>
Co-authored-by: Alexxxxxx <[email protected]>
j75689 added a commit to j75689/greenfield that referenced this pull request Jul 12, 2023
@j75689
Revert "fix: cherrypicked commits bnb-chain#285 bnb-chain#295 (bnb-ch…
1ac68bf 
…ain#335)"

This reverts commit e4146e0.
@unclezoro unclezoro deleted the fix-update-object-info branch August 16, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

@fynnss fynnss fynnss approved these changes

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingjunLi @fynnss @forcodedancing