correct emit event filed (#458)

bnb-chain · Sep 6, 2023 · 9fd4c68 · 9fd4c68
1 parent e903864
commit 9fd4c68
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/proto/greenfield/sp/tx.proto b/proto/greenfield/sp/tx.proto
@@ -35,7 +35,7 @@ message MsgCreateStorageProvider {
 
   // creator is the msg signer
   string creator = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
-  // description defines the description terms for the validator.
+  // description defines the description terms for the storage provider.
   Description description = 2 [(gogoproto.nullable) = false];
   // sp_address defines the address of the sp's operator; It also is the unqiue index key of sp.
   string sp_address = 3 [(cosmos_proto.scalar) = "cosmos.AddressString"];

diff --git a/x/sp/client/cli/tx.go b/x/sp/client/cli/tx.go
@@ -52,7 +52,7 @@ func CmdCreateStorageProvider() *cobra.Command {
 		Long:  `Submit a create new storage provider proposal by submitting a JSON file with the new storage provider details, once the proposal has been passed, create a new storage provider initialized with a self deposit.`,
 		Example: strings.TrimSpace(
 			fmt.Sprintf(`
-$ %s tx sp create-storage-provider path/to/create_validator_proposal.json --from keyname
+$ %s tx sp create-storage-provider path/to/create_sp_proposal.json --from keyname
 Where create_storagep_provider.json contains:
 {
   "messages": [
@@ -421,9 +421,9 @@ func CreateStorageProviderMsgFlagSet(ipDefault string) (fs *flag.FlagSet, defaul
 	fsCreateStorageProvider.String(FlagNodeID, "", "The node's NodeID")
 
 	fsCreateStorageProvider.String(FlagMoniker, "", "The sp's name")
-	fsCreateStorageProvider.String(FlagWebsite, "", "The validator's (optional) website")
-	fsCreateStorageProvider.String(FlagSecurityContact, "", "The validator's (optional) security contact email")
-	fsCreateStorageProvider.String(FlagDetails, "", "The validator's (optional) details")
+	fsCreateStorageProvider.String(FlagWebsite, "", "The storage provider's (optional) website")
+	fsCreateStorageProvider.String(FlagSecurityContact, "", "The storage provider's (optional) security contact email")
+	fsCreateStorageProvider.String(FlagDetails, "", "The storage provider's (optional) details")
 	fsCreateStorageProvider.String(FlagIdentity, "", "The (optional) identity signature (ex. UPort or Keybase)")
 
 	fsCreateStorageProvider.String(FlagCreator, "", "The creator address of storage provider")

diff --git a/x/sp/types/tx.pb.go b/x/sp/types/tx.pb.go
diff --git a/x/sp/types/types.go b/x/sp/types/types.go
@@ -112,7 +112,7 @@ func NewDescription(moniker, identity, website, details string) Description {
 	}
 }
 
-// EnsureLength ensures the length of a validator's description.
+// EnsureLength ensures the length of a storage provider's description.
 func (d *Description) EnsureLength() error {
 	if len(d.Moniker) > MaxMonikerLength {
 		return errors.Wrapf(sdkerrors.ErrInvalidRequest, "invalid moniker length; got: %d, max: %d", len(d.Moniker), MaxMonikerLength)

diff --git a/x/storage/keeper/keeper.go b/x/storage/keeper/keeper.go
@@ -2020,7 +2020,7 @@ func (k Keeper) CompleteMigrateBucket(ctx sdk.Context, operator sdk.AccAddress,
 		BucketName:                 bucketName,
 		BucketId:                   bucketInfo.Id,
 		GlobalVirtualGroupFamilyId: gvgFamilyID,
-		SrcPrimarySpId:             srcGvgFamily.Id,
+		SrcPrimarySpId:             srcGvgFamily.PrimarySpId,
 	}); err != nil {
 		return err
 	}