check secondary sp in gvg

bnb-chain · Aug 24, 2023 · 650c1fe · 650c1fe
1 parent 02e9014
commit 650c1fe
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/x/virtualgroup/keeper/msg_server.go b/x/virtualgroup/keeper/msg_server.go
@@ -70,6 +70,10 @@ func (k msgServer) CreateGlobalVirtualGroup(goCtx context.Context, req *types.Ms
 		if !found {
 			return nil, sdkerrors.Wrapf(sptypes.ErrStorageProviderNotFound, "secondary sp not found, ID: %d", id)
 		}
+		if !ssp.IsInService() && !ssp.IsInMaintenance() {
+			return nil, sptypes.ErrStorageProviderNotInService.Wrapf("sp in GVG is not in service or in maintenance, status: %s", sp.Status.String())
+		}
+
 		secondarySpIds = append(secondarySpIds, ssp.Id)
 		gvgStatisticsWithinSP := k.GetOrCreateGVGStatisticsWithinSP(ctx, ssp.Id)
 		gvgStatisticsWithinSP.SecondaryCount++