fix: principal value supports group name (#626)

* fix: principal value supports group name * fix: principal value supports group name
bnb-chain · May 28, 2024 · 37eb89f · 37eb89f
1 parent e418737
commit 37eb89f
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 13 deletions.
diff --git a/proto/greenfield/permission/common.proto b/proto/greenfield/permission/common.proto
@@ -79,6 +79,8 @@ enum PrincipalType {
 message Principal {
   PrincipalType type = 1;
   // When the type is an account, its value is sdk.AccAddress().String();
-  // when the type is a group, its value is math.Uint().String()
+  // When the type is a group, its value can be in one of two formats:
+  // 1. group id
+  // 2. grn:g:ownerAddress:groupName
   string value = 2;
 }
diff --git a/swagger/static/swagger.yaml b/swagger/static/swagger.yaml
@@ -5201,8 +5201,12 @@ paths:
                           When the type is an account, its value is
                           sdk.AccAddress().String();
 
-                          when the type is a group, its value is
-                          math.Uint().String()
+                          When the type is a group, its value can be in one of
+                          two formats:
+
+                          1. group id
+
+                          2. grn:g:ownerAddress:groupName
                     description: >-
                       Principal define the roles that can be grant permissions
                       to. Currently, it can be account or group.
@@ -5397,8 +5401,12 @@ paths:
                           When the type is an account, its value is
                           sdk.AccAddress().String();
 
-                          when the type is a group, its value is
-                          math.Uint().String()
+                          When the type is a group, its value can be in one of
+                          two formats:
+
+                          1. group id
+
+                          2. grn:g:ownerAddress:groupName
                     description: >-
                       Principal define the roles that can be grant permissions
                       to. Currently, it can be account or group.
@@ -5597,8 +5605,12 @@ paths:
                           When the type is an account, its value is
                           sdk.AccAddress().String();
 
-                          when the type is a group, its value is
-                          math.Uint().String()
+                          When the type is a group, its value can be in one of
+                          two formats:
+
+                          1. group id
+
+                          2. grn:g:ownerAddress:groupName
                     description: >-
                       Principal define the roles that can be grant permissions
                       to. Currently, it can be account or group.
@@ -34654,7 +34666,11 @@ definitions:
               When the type is an account, its value is
               sdk.AccAddress().String();
 
-              when the type is a group, its value is math.Uint().String()
+              When the type is a group, its value can be in one of two formats:
+
+              1. group id
+
+              2. grn:g:ownerAddress:groupName
         description: >-
           Principal define the roles that can be grant permissions to.
           Currently, it can be account or group.
@@ -34784,7 +34800,9 @@ definitions:
         type: string
         title: |-
           When the type is an account, its value is sdk.AccAddress().String();
-          when the type is a group, its value is math.Uint().String()
+          When the type is a group, its value can be in one of two formats:
+          1. group id
+          2. grn:g:ownerAddress:groupName
     description: >-
       Principal define the roles that can be grant permissions to. Currently, it
       can be account or group.
@@ -36657,7 +36675,12 @@ definitions:
                   When the type is an account, its value is
                   sdk.AccAddress().String();
 
-                  when the type is a group, its value is math.Uint().String()
+                  When the type is a group, its value can be in one of two
+                  formats:
+
+                  1. group id
+
+                  2. grn:g:ownerAddress:groupName
             description: >-
               Principal define the roles that can be grant permissions to.
               Currently, it can be account or group.
@@ -36811,7 +36834,12 @@ definitions:
                   When the type is an account, its value is
                   sdk.AccAddress().String();
 
-                  when the type is a group, its value is math.Uint().String()
+                  When the type is a group, its value can be in one of two
+                  formats:
+
+                  1. group id
+
+                  2. grn:g:ownerAddress:groupName
             description: >-
               Principal define the roles that can be grant permissions to.
               Currently, it can be account or group.
@@ -36965,7 +36993,12 @@ definitions:
                   When the type is an account, its value is
                   sdk.AccAddress().String();
 
-                  when the type is a group, its value is math.Uint().String()
+                  When the type is a group, its value can be in one of two
+                  formats:
+
+                  1. group id
+
+                  2. grn:g:ownerAddress:groupName
             description: >-
               Principal define the roles that can be grant permissions to.
               Currently, it can be account or group.

diff --git a/x/permission/types/common.pb.go b/x/permission/types/common.pb.go