chore: add more test cases for cross chain apps

bnb-chain · Jul 28, 2023 · 1a01e8e · 1a01e8e
1 parent 186de54
commit 1a01e8e
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 6 deletions.
diff --git a/x/storage/keeper/cross_app_bucket_test.go b/x/storage/keeper/cross_app_bucket_test.go
@@ -13,12 +13,6 @@ import (
 )
 
 func (s *TestSuite) TestSynDeleteBucket() {
-	pack := types.DeleteBucketAckPackage{
-		Status:    1,
-		Id:        big.NewInt(10),
-		ExtraData: []byte("x"),
-	}
-	pack.MustSerialize()
 	ctrl := gomock.NewController(s.T())
 	storageKeeper := types.NewMockStorageKeeper(ctrl)
 	storageKeeper.EXPECT().Logger(gomock.Any()).Return(s.ctx.Logger()).AnyTimes()
@@ -55,3 +49,46 @@ func (s *TestSuite) TestSynDeleteBucket() {
 	res = app.ExecuteSynPackage(s.ctx, nil, serializedSynPackage)
 	s.Require().NoError(res.Err)
 }
+
+func (s *TestSuite) TestSynCreateBucket() {
+	ctrl := gomock.NewController(s.T())
+	storageKeeper := types.NewMockStorageKeeper(ctrl)
+	storageKeeper.EXPECT().Logger(gomock.Any()).Return(s.ctx.Logger()).AnyTimes()
+
+	app := keeper.NewBucketApp(storageKeeper)
+	createSynPackage := types.CreateBucketSynPackage{
+		Creator:          sample.RandAccAddress(),
+		BucketName:       "bucketname",
+		ExtraData:        []byte("extra data"),
+		PaymentAddress:   sample.RandAccAddress(),
+		PrimarySpAddress: sample.RandAccAddress(),
+	}
+	serializedSynPackage := createSynPackage.MustSerialize()
+	serializedSynPackage = append([]byte{types.OperationCreateBucket}, serializedSynPackage...)
+
+	// case 1: invalid package
+	res := app.ExecuteSynPackage(s.ctx, nil, serializedSynPackage)
+	s.Require().ErrorContains(res.Err, "Invalid type of visibility")
+
+	// case 2: create bucket error
+	createSynPackage.Visibility = uint32(types.VISIBILITY_TYPE_PUBLIC_READ)
+	serializedSynPackage = createSynPackage.MustSerialize()
+	serializedSynPackage = append([]byte{types.OperationCreateBucket}, serializedSynPackage...)
+
+	storageKeeper.EXPECT().CreateBucket(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(sdk.NewUint(1), fmt.Errorf("create error"))
+	res = app.ExecuteSynPackage(s.ctx, nil, serializedSynPackage)
+	s.Require().ErrorContains(res.Err, "create error")
+
+	// case 3: create bucket success
+	createSynPackage.Visibility = uint32(types.VISIBILITY_TYPE_PUBLIC_READ)
+	serializedSynPackage = createSynPackage.MustSerialize()
+	serializedSynPackage = append([]byte{types.OperationCreateBucket}, serializedSynPackage...)
+
+	storageKeeper.EXPECT().CreateBucket(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(sdk.NewUint(1), nil)
+	res = app.ExecuteSynPackage(s.ctx, nil, serializedSynPackage)
+	s.Require().NoError(res.Err)
+}
+
+func (s *TestSuite) TestAckMirrorBucket() {
+
+}
diff --git a/x/storage/types/crosschain.go b/x/storage/types/crosschain.go
@@ -381,6 +381,24 @@ var (
 	}
 )
 
+func (p CreateBucketSynPackage) MustSerialize() []byte {
+	encodedBytes, err := createBucketSynPackageStructArgs.Pack(&CreateBucketSynPackageStruct{
+		Creator:                        common.BytesToAddress(p.Creator),
+		BucketName:                     p.BucketName,
+		Visibility:                     p.Visibility,
+		PaymentAddress:                 common.BytesToAddress(p.PaymentAddress),
+		PrimarySpAddress:               common.BytesToAddress(p.PrimarySpAddress),
+		PrimarySpApprovalExpiredHeight: p.PrimarySpApprovalExpiredHeight,
+		PrimarySpApprovalSignature:     p.PrimarySpApprovalSignature,
+		ChargedReadQuota:               p.ChargedReadQuota,
+		ExtraData:                      p.ExtraData,
+	})
+	if err != nil {
+		panic("encode create bucket syn package error")
+	}
+	return encodedBytes
+}
+
 func (p CreateBucketSynPackage) ValidateBasic() error {
 	msg := MsgCreateBucket{
 		Creator:          p.Creator.String(),