Merge pull request #587 from alexgao001/fix-discontinue-unlock-shadow…

…object

fix: disallow copy an object is being updated

x/storage/keeper/keeper.go

@@ -811,7 +811,9 @@ func (k Keeper) SealObject(
 	prevCheckSums := objectInfo.Checksums
 
 	isUpdate := objectInfo.IsUpdating
-	if isUpdate {
+
+	// an object might be set to OBJECT_STATUS_DISCONTINUED
+	if isUpdate && objectInfo.ObjectStatus == types.OBJECT_STATUS_SEALED {
 		internalBucketInfo := k.MustGetInternalBucketInfo(ctx, bucketInfo.Id)
 		err := k.UnChargeObjectStoreFee(ctx, bucketInfo, internalBucketInfo, objectInfo)
 		if err != nil {
@@ -1151,6 +1153,10 @@ func (k Keeper) CopyObject(
 		return sdkmath.ZeroUint(), types.ErrSourceTypeMismatch
 	}
 
+	if srcObjectInfo.IsUpdating {
+		return sdkmath.ZeroUint(), types.ErrAccessDenied.Wrapf("the object is being updated, can not be copied")
+	}
+
 	// check permission
 	effect := k.VerifyObjectPermission(ctx, srcBucketInfo, srcObjectInfo, operator, permtypes.ACTION_COPY_OBJECT)
 	if effect != permtypes.EFFECT_ALLOW {