cmd, core: resolve scheme from a read-write database and refactor resolveChainFreezerDir func #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts
zzzckck
previously approved these changes
Jan 12, 2024
joeylichang
changed the title
buddh0
approved these changes
Jan 15, 2024
sysvm
changed the title
fynnss
approved these changes
Jan 19, 2024
zzzckck
approved these changes
Jan 19, 2024
|
After this pr is merged, 48Club needs to use new release version to run geth. Because current PBSS snapshot is incorrect, there is no state directory in ancient directory. Use new version to generate state directory. |
thank you for everything! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request solves four pull requests: #2110, #2131, #2141, #2146
This issue can occur when unclean shutdown happens and freezer tables need to be repair. In database read-only mode, the freezer will only be validated but not repair and terminates the node abnormally.
This pull request moves the scheme check into the Ethereum constructor where the read-write database is already initialized. This approach can avoid opening read-only database in very early stage, to prevent this error totally.
Current geth doesn't deal with chain freezer dir in a good way. Therefore, this pr refactors
resolveChainFreezerDirto fix in pruned and non-pruned mode.Rationale
These will influence how should users use
pruenancientmode that block data could be replaced in which.Example
N/A
Changes
Notable changes: