core/state: no need to prune block if the same #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvisa
force-pushed
the
bugfix/prune-block-ancient-dir
branch
from
0fefa12
to
282e7db
Compare
|
@brilliant-lx and please take a look at this one |
brilliant-lx
previously approved these changes
May 6, 2023
got it, thx |
jsvisa
force-pushed
the
bugfix/prune-block-ancient-dir
branch
2 times, most recently
from
eafdf1c
to
aaa29e7
Compare
joeylichang
previously approved these changes
Jan 9, 2024
jsvisa
dismissed
joeylichang’s stale review
The merge-base changed after approval.
|
LGTM, it checks the |
jsvisa
dismissed
RenRick’s stale review
The merge-base changed after approval.
|
@jsvisa could you rebase your branch to latest develop? |
|
@jsvisa could you rebase your branch? or we may create a separate PR to include your change. |
Signed-off-by: Delweng <[email protected]>
This reverts commit 1bbd4b8. Signed-off-by: Delweng <[email protected]>
Signed-off-by: Delweng <[email protected]>
jsvisa
force-pushed
the
bugfix/prune-block-ancient-dir
branch
from
aaa29e7
to
d0539a4
Compare
|
@zzzckck sorry for the late reply, finished rebasing. |
joeylichang
approved these changes
Jan 22, 2024
zzzckck
approved these changes
Jan 22, 2024
zzzckck
changed the title
This was referenced Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't need to run
prune-blockif specified reserve blocks are the same to items in ancientdb