Fixed H5Ovisit2 change of behavior between 1.10.11 and v1.14.4.3

In H5O_get_info() of 1.10.11:
    HDmemset(oinfo, 0, sizeof(*oinfo))
set oinfo->type to 0, which was also the value of H5O_TYPE_GROUP, so
oinfo->type accidentally had a correct value when the object was a group.

If oinfo->type were initialized to H5O_TYPE_UNKNOWN as it should be, the
application would have behaved the same way as with 1.14.3, whose H5O_get_info()
called H5O__reset_info2() that set oinfo->type to H5O_TYPE_UNKNOWN.
So, it was a case of coincidentally correct behavior in 1.10.11.

The fix is to assign the correct value to oinfo->type early on instead
of only when the requested info is H5O_INFO_BASIC.  For that matter, probably
all or some of the fields being set in the H5O_INFO_BASIC block should be
changed the same way to prevent similar potential errors.

(GH HDFGroup#2136)

src/H5Oint.c

@@ -2075,8 +2075,9 @@ H5O__get_hdr_info_real(const H5O_t *oh, H5O_hdr_info_t *hdr)
 herr_t
 H5O_get_info(const H5O_loc_t *loc, H5O_info2_t *oinfo, unsigned fields)
 {
-    H5O_t *oh        = NULL;    /* Object header */
-    herr_t ret_value = SUCCEED; /* Return value */
+    H5O_t     *oh        = NULL;    /* Object header */
+    H5O_type_t obj_type  = H5O_TYPE_UNKNOWN; /* Type of object */
+    herr_t     ret_value = SUCCEED; /* Return value */
 
     FUNC_ENTER_NOAPI_TAG(loc->addr, FAIL)
 
@@ -2092,9 +2093,13 @@ H5O_get_info(const H5O_loc_t *loc, H5O_info2_t *oinfo, unsigned fields)
     if (H5O__reset_info2(oinfo) < 0)
         HGOTO_ERROR(H5E_OHDR, H5E_CANTSET, FAIL, "can't reset object data struct");
 
+    /* Get type of object */
+    if (H5O__obj_type_real(oh, &obj_type) < 0)
+        HGOTO_ERROR(H5E_OHDR, H5E_CANTGET, FAIL, "unable to determine object type");
+    oinfo->type = obj_type;
+
     /* Get basic information, if requested */
     if (fields & H5O_INFO_BASIC) {
-        H5O_type_t obj_type = H5O_TYPE_UNKNOWN; /* Type of object */
 
         /* Retrieve the file's fileno */
         H5F_GET_FILENO(loc->file, oinfo->fileno);
@@ -2103,13 +2108,6 @@ H5O_get_info(const H5O_loc_t *loc, H5O_info2_t *oinfo, unsigned fields)
         if (H5VL_native_addr_to_token(loc->file, H5I_FILE, loc->addr, &oinfo->token) < 0)
             HGOTO_ERROR(H5E_OHDR, H5E_CANTSERIALIZE, FAIL, "can't serialize address into object token");
 
-        /* Get type of object */
-        if (H5O__obj_type_real(oh, &obj_type) < 0)
-            HGOTO_ERROR(H5E_OHDR, H5E_CANTGET, FAIL, "unable to determine object type");
-
-        /* Set the type of the object */
-        oinfo->type = obj_type;
-
         /* Set the object's reference count */
         oinfo->rc = oh->nlink;
     }