Incorporate review findings + some frontend #2
Annotations
3 errors and 11 warnings
build:
review-ui/Ahk.Review.Ui/Services/AssignmentService.cs#L35
Cannot implicitly convert type 'System.Collections.Generic.IReadOnlyCollection<DTOs.AssignmentDTO>' to 'System.Collections.Generic.IReadOnlyCollection<Ahk.Review.Ui.Models.Assignment>'. An explicit conversion exists (are you missing a cast?)
|
build:
review-ui/Ahk.Review.Ui/Services/AssignmentService.cs#L35
Cannot implicitly convert type 'System.Collections.Generic.IReadOnlyCollection<DTOs.AssignmentDTO>' to 'System.Collections.Generic.IReadOnlyCollection<Ahk.Review.Ui.Models.Assignment>'. An explicit conversion exists (are you missing a cast?)
|
build
Process completed with exit code 1.
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build:
grade-management/DTOs/AssignmentDTO.cs#L12
Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/AssignmentDTO.cs#L14
Non-nullable property 'ClassroomAssignment' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/AssignmentDTO.cs#L15
Non-nullable property 'Exercises' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/ExerciseDTO.cs#L13
Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/WebhookTokenDTO.cs#L11
Non-nullable property 'Id' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/WebhookTokenDTO.cs#L12
Non-nullable property 'Secret' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/WebhookTokenDTO.cs#L13
Non-nullable property 'Description' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/UserDTO.cs#L12
Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/UserDTO.cs#L13
Non-nullable property 'Neptun' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
build:
grade-management/DTOs/UserDTO.cs#L14
Non-nullable property 'EduEmail' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|