Incorporate review findings + some frontend #9
balintgroberAnnotations
3 errors and 11 warnings
|
build:
grade-management/Ahk.GradeManagement.Tests/IntegrationTests/Helpers/FunctionCallAssert.cs#L5
The type or namespace name 'Internal' does not exist in the namespace 'Microsoft.AspNetCore.Http' (are you missing an assembly reference?)
|
|
build:
grade-management/Ahk.GradeManagement.Tests/IntegrationTests/Helpers/FunctionCallAssert.cs#L5
The type or namespace name 'Internal' does not exist in the namespace 'Microsoft.AspNetCore.Http' (are you missing an assembly reference?)
|
|
build
Process completed with exit code 1.
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Exercise.cs#L20
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Point.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Student.cs#L14
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Assignment.cs#L21
Change 'StudentAssignments' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Assignment.cs#L16
Change 'Exercises' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Grade.cs#L20
Change 'Points' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Group.cs#L18
Change 'StudentGroups' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Group.cs#L19
Change 'TeacherGroups' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/StatusTracking/PullRequestEvent.cs#L18
Change 'Assignees' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
grade-management/Ahk.GradeManagement.Data/Entities/Student.cs#L11
Change 'StudentAssignments' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|