Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back SDXL Parameters accordion for dreambooth gui #2694

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

b-fission
Copy link
Contributor

The SDXL options panel has been missing in the dreambooth tab for a while.
Fixed first part of issue #2542

@b-fission b-fission changed the title bring back SDXLConfig accordion for dreambooth gui bring back SDXL Parameters accordion for dreambooth gui Aug 6, 2024
@b-fission
Copy link
Contributor Author

When cache_text_encoder_outputs is enabled, the training script will fail with a data type error. That error didn't happen in v24.1.4 ... it looks like v24.1.5 pulled in a dev branch of sd-scripts because I see SD3 related code in there.

@bmaltais
Copy link
Owner

bmaltais commented Aug 9, 2024

Hi, wonder since when this has been missing. Did I somehow broke the code and removed SDXL support in Dreambooth?

@bmaltais
Copy link
Owner

bmaltais commented Aug 9, 2024

When cache_text_encoder_outputs is enabled, the training script will fail with a data type error. That error didn't happen in v24.1.4 ... it looks like v24.1.5 pulled in a dev branch of sd-scripts because I see SD3 related code in there.

Humm... Perhaps I commited the wrong sd-scripts branch in my last dev branch commit... LE me fix that...

@bmaltais bmaltais changed the base branch from master to dev August 9, 2024 00:36
@bmaltais
Copy link
Owner

bmaltais commented Aug 9, 2024

Is it possible this has been missing all along? I must have forgotten to add it in there... not one complained about it missing ;-)

OK, I will merge the change as it appear to add missing parameters...

@bmaltais bmaltais merged commit d714691 into bmaltais:dev Aug 9, 2024
1 check passed
@b-fission
Copy link
Contributor Author

b-fission commented Aug 9, 2024

Is it possible this has been missing all along? I must have forgotten to add it in there... not one complained about it missing ;-)

It was missing in the master branch. It's already present and working in dev before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants