Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💉 Add health check for hosting containerized tiled instances #770

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

Kezzsim
Copy link
Contributor

@Kezzsim Kezzsim commented Jul 17, 2024

Kubernetes and other container orchestration platforms require pods that expose themselves as services to prove that they are alive and ready to handle HTTP responses, while this response can be baked into deployment yml, it's considered best practice to actually have the service return something indicating that it is healthy.

This implements the spec defined in the Kubernetes Readyness Probe section.

This resolves part of issue #648

@Kezzsim Kezzsim merged commit 2e392d6 into bluesky:main Jul 17, 2024
9 checks passed
@dylanmcreynolds
Copy link
Contributor

This is great.

Is there any configuration you have to do in k8s to invoke this, or is it automagic?

There is a docker-compose.yml in the root of the tiled repo. Perhaps this is a future PR, but it might be nice to add the health check to it, now that it's possible. Here's an example

@Kezzsim
Copy link
Contributor Author

Kezzsim commented Jul 19, 2024

Good idea!
Yeah we rushed this PR through on a call so we could deploy to our Rancher instance, the /healthz endpoint check is standard in spec and seems to work with any Kubernetes instance out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants