Fix username logging on 500 responses. #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug causes the server to send no response, such that the client raised: ``` RemoteProtocolError: Server disconnected without sending a response. ``` instead of returning 500 response. This was a regression introduced in bluesky#750. Needs test. Closes bluesky#750
|
The unit test added in 485672a, when run on the |
|
Confirmed again that introducing a bug... diff --git a/tiled/server/principal_log_filter.py b/tiled/server/principal_log_filter.py
index cf5a534f..59dd0e86 100644
--- a/tiled/server/principal_log_filter.py
+++ b/tiled/server/principal_log_filter.py
@@ -9,6 +9,7 @@ class PrincipalFilter(Filter):
def filter(self, record: LogRecord) -> bool:
principal = current_principal.get(None)
+ raise Exception
if principal is None:
# This will only occur if an uncaught exception was raised in the
# server before the authentication code ran. This will always be...fails the new unit test: |
|
Self-merging as a hotfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug causes the server to send no response, such that the client raised:
instead of returning 500 response. This was a regression introduced in #750.
Needs test.
Closes #753
Checklist