Skip duplicate data during copy from one catalog to another #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from comment on #735, this PR provides extremely rudimentary duplicate skipping during a
tiled.client.sync.copy
.I think it makes sense to put this behavior behind a flagDuplicate handling is a little tricky for performance; I think the scope ofskip_duplicates
and leave it False by default..copy()
is pretty clear that it doesn't update nodes in the destination catalog if the source has changed (though this, of course, might eventually be desirable behavior).(edit per @danielballan's suggestion below: this flag is now a str called
on_conflict
with implemented options 'error' (default), 'warn', and 'skip')Checklist