Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO should be lower case to be consistent with others in this module #1211

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

prjemian
Copy link
Contributor

Somehow, this missed testing. A long time ago.

    tetramm = TetrAMM("8idTetra:QUAD1:", name="tetramm")
    for axis in "x y".split():
        for attr_name in "offset offset_calc scale".split():
            getattr(tetramm, f"position_{attr_name}_{axis}").kind = "config"
AttributeError: position_scale_y

@prjemian prjemian added the bug label Sep 20, 2024
@prjemian prjemian self-assigned this Sep 20, 2024
@prjemian
Copy link
Contributor Author

We can get by without this change (which might break existing usage) with:

    for attr_name in tetramm.component_names:
        attr = getattr(tetramm, attr_name)
        if attr_name.startswith("current_"):
            for ch_name in attr.component_names:
                getattr(attr, ch_name).kind = "config"
        elif attr_name.startswith("position_"):
            attr.kind = "config"

But for sure, all these components need to be kind="config".

@prjemian prjemian merged commit 27f9fd7 into master Sep 21, 2024
14 checks passed
@prjemian prjemian deleted the TYPO-in-quadem branch September 21, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants