-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure code base and ensure tests still pass #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much there, I'm more on the "multiple classes per file" side of the fence, but a quick poll of the office suggests I'm in the minority, so I think you are right with your file splitting decisions.
I would like to reduce the import namespace however, so the top level namespace should be:
core
epics.signal
epics.areadetector
panda
and those namespaces should be populated with__init__.py
s that only import from modules that start with_
docs/developer/explanations/decisions/0004-repository-structure.rst
Outdated
Show resolved
Hide resolved
80b0710
to
29a09b3
Compare
No description provided.