Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PVI devices to be initialized before connection #241

Merged
merged 36 commits into from
Jun 10, 2024
Merged

Allow PVI devices to be initialized before connection #241

merged 36 commits into from
Jun 10, 2024

Conversation

noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Apr 18, 2024 •
edited
Loading

Fixes #194

Requires #185

@evalott100
Copy link
Contributor

@noemifrisina where are we with this? Should someone else take over?

@noemifrisina
Copy link
Contributor Author

I was waiting for #185 to be merged - and didn't notice it had been. Can pick it up by end of the week if you don't need it sooner...

@evalott100
Copy link
Contributor

evalott100 commented May 23, 2024 •
edited
Loading

Is this waiting for a review? I'm happy to take over - we need the connect time signal backends pretty soon.

@noemifrisina
Copy link
Contributor Author

Is this waiting for a review? I'm happy to take over - we need the connect time signal backends pretty soon.

The backend part of this is ready for review.
The change to the blocks initialisation in create_children_from_annotations I'm not sure as it's been awhile.
I committed some change I had stashed and merged things from main. I think it would be good to start a review also to see what is still missing?

@noemifrisina noemifrisina marked this pull request as ready for review May 30, 2024 14:30
evalott100
evalott100 requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things 🙏

src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/pvi/pvi.py Outdated Show resolved Hide resolved
tests/core/test_signal.py Outdated Show resolved Hide resolved
tests/core/test_signal.py Outdated Show resolved Hide resolved
tests/core/test_signal.py Outdated Show resolved Hide resolved
evalott100
evalott100 requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, two more tests required!

src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
tests/core/test_signal.py Outdated Show resolved Hide resolved
tests/core/test_signal.py Show resolved Hide resolved
src/ophyd_async/epics/pvi/pvi.py Show resolved Hide resolved
evalott100
evalott100 requested changes Jun 7, 2024
View reviewed changes
src/ophyd_async/epics/pvi/pvi.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/pvi/pvi.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/pvi/pvi.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/pvi/pvi.py Outdated Show resolved Hide resolved
tests/core/test_signal.py Outdated Show resolved Hide resolved
evalott100
evalott100 requested changes Jun 10, 2024
View reviewed changes
tests/epics/test_pvi.py Outdated Show resolved Hide resolved
tests/epics/test_pvi.py Outdated Show resolved Hide resolved
evalott100
evalott100 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, thanks very much!

@evalott100 evalott100 merged commit cbbb295 into bluesky:main Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evalott100 evalott100 evalott100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow common pvi devices to be initialized pre-connection and allow Signal.connect to take a backend
2 participants
@noemifrisina @evalott100