Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Copier template #207

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Adopt Copier template #207

merged 10 commits into from
Apr 18, 2024

Conversation

DiamondJoseph
Copy link
Contributor

Closes #158

  • Additionally ignores .vscode/
  • Retains BSD license

Copy link
Contributor

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Herculean effort!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not rendering properly.

I could not work out why that was the case.

also search is not working - is this something up with the Myst config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search not working I believe is related to another issue

README.md Show resolved Hide resolved
@DiamondJoseph DiamondJoseph force-pushed the copierfy branch 2 times, most recently from 54db1db to 9451919 Compare April 17, 2024 15:09
@gilesknap
Copy link
Contributor

gilesknap commented Apr 18, 2024

@DiamondJoseph 🤓 Yay! I am rebased over your branch and my CI is completing. Thanks for this!
https://github.com/gilesknap/ophyd-async/actions/runs/8733539688

I believe this is ready to (rebase and) merge.

@DiamondJoseph DiamondJoseph force-pushed the copierfy branch 2 times, most recently from de0315c to 9451919 Compare April 18, 2024 08:03
@coretl coretl closed this Apr 18, 2024
@coretl coretl reopened this Apr 18, 2024
@DiamondJoseph DiamondJoseph merged commit 8db90d2 into main Apr 18, 2024
27 checks passed
@DiamondJoseph DiamondJoseph deleted the copierfy branch April 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Copier Template
3 participants