-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.9 support #171
Conversation
00770f7
to
e6a7b7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to rebase off main and merge, boy I can't wait to use match statements again 🙏 😭
@evalott100 What's with these tests which never run? Are they expected by some repo settings? |
They're for the different situations - i.e on a "release" the release ones will be ran... It's strange you have two pending tests not categorised like the others, not sure why this would be happening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are required by some repo settings not in the code - as you can see with the latest commit, running the 3.10 tests with editable install satisfied the expectation for that - while the 3.9 one is not satisfied because it is no longer being run, because it is removed from the actions. I don't have permissions to update the branch protection rules here, some admin needs to do that - @coretl ? |
done |
According to NEP-29 we can now drop python 3.9 🎉
This makes many nice 3.10 features available, such as
ParamSpec
and getting rid ofOptional
andUnion
for|
.