Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.9 support #171

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Drop python 3.9 support #171

merged 5 commits into from
Apr 15, 2024

Conversation

dperl-dls
Copy link
Contributor

@dperl-dls dperl-dls commented Apr 4, 2024

According to NEP-29 we can now drop python 3.9 🎉
This makes many nice 3.10 features available, such as ParamSpec and getting rid of Optional and Union for |.

@dperl-dls dperl-dls force-pushed the drop_py_3_9 branch 2 times, most recently from 00770f7 to e6a7b7a Compare April 4, 2024 09:13
@dperl-dls dperl-dls marked this pull request as ready for review April 4, 2024 15:03
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to rebase off main and merge, boy I can't wait to use match statements again 🙏 😭

@dperl-dls
Copy link
Contributor Author

@evalott100 What's with these tests which never run? Are they expected by some repo settings?

@evalott100
Copy link
Contributor

@evalott100 What's with these tests which never run? Are they expected by some repo settings?

They're for the different situations - i.e on a "release" the release ones will be ran...

It's strange you have two pending tests not categorised like the others, not sure why this would be happening

Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this has introduced these:

image

@dperl-dls
Copy link
Contributor Author

dperl-dls commented Apr 12, 2024

I think they are required by some repo settings not in the code - as you can see with the latest commit, running the 3.10 tests with editable install satisfied the expectation for that - while the 3.9 one is not satisfied because it is no longer being run, because it is removed from the actions. I don't have permissions to update the branch protection rules here, some admin needs to do that - @coretl ?

@coretl
Copy link
Collaborator

coretl commented Apr 15, 2024

done

@coretl coretl closed this Apr 15, 2024
@coretl coretl reopened this Apr 15, 2024
@coretl coretl merged commit f7f651c into main Apr 15, 2024
19 checks passed
@coretl coretl deleted the drop_py_3_9 branch April 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants