-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: src: device: manager: Panic when call unimplemented options #6
Fix: src: device: manager: Panic when call unimplemented options #6
Conversation
src/device/manager.rs
Outdated
.respond_to | ||
.send(Err(ManagerError::NotImplemented(actor_request.request))) | ||
{ | ||
warn!("DeviceManager: Failed to return response: {:?}", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We often prefer to use it like {e:?}
, but I don't know if this repo is following this idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some habits are difficult to break, I learned this way when was learning C haha
I'm going to apply and keep this stantandard then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some special cases that seems it doesn't work:
warn!(
"Unsupported request for device type: {:?}",
&self.device_type
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @joaoantoniocardoso
Please check the newer commit below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems all right
…p variables inside log description, following our current standards
No description provided.