Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo: Fix serde feature #50

Merged
merged 1 commit into from
May 27, 2024
Merged

Cargo: Fix serde feature #50

merged 1 commit into from
May 27, 2024

Conversation

patrickelectric
Copy link
Member

No description provided.

@patrickelectric
Cargo: Fix serde feature
5b54b93 
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric patrickelectric mentioned this pull request May 27, 2024
Closed
@RaulTrombin
Copy link
Member

Would be nice to have features/no-features building tested on CI,
To avoid any future incompatibility as we add new components, last PRs fixed then, but could be avoided.

RaulTrombin
RaulTrombin approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@RaulTrombin RaulTrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!
tested with serde_json() with default,
--no-feault-features fails as expected.

@patrickelectric patrickelectric merged commit 0a12577 into bluerobotics:master May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaulTrombin RaulTrombin RaulTrombin approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickelectric @RaulTrombin