Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: parser: Fix: Fix vector payload #17

Merged
merged 1 commit into from
Apr 9, 2024
Merged

build: parser: Fix: Fix vector payload #17

merged 1 commit into from
Apr 9, 2024

Conversation

RaulTrombin
Copy link
Member

It fixes Issue 16.
Only works if last payload content is a single vector.

@RaulTrombin RaulTrombin marked this pull request as draft April 9, 2024 00:13
@RaulTrombin RaulTrombin marked this pull request as ready for review April 9, 2024 13:42
patrickelectric
patrickelectric approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify on that, #b is the known number of bytes in the payload and payload_len is the total number including such bytes.

@patrickelectric patrickelectric merged commit c5db3e1 into bluerobotics:master Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Ping protocol generating wrong Ping1D deserealization
2 participants
@RaulTrombin @patrickelectric