Create a channel stantard #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaulTrombin
force-pushed
the
channel_stantard
branch
3 times, most recently
from
d9ea8e6
to
d771ec2
Compare
RaulTrombin
force-pushed
the
channel_stantard
branch
2 times, most recently
from
451dbcd
to
561df6e
Compare
src/lib.rs
Outdated
| pub fn set_pwm_channels_values<const N: usize>( | ||
| &mut self, | ||
| channels: &[pwm_Channel; N], | ||
| values: &[u16; N], | ||
| channels: [PwmChannel; N], |
There was a problem hiding this comment.
why we moved from reference to own the list ?
RaulTrombin
force-pushed
the
channel_stantard
branch
3 times, most recently
from
e99b52b
to
0a3e34a
Compare
src/lib.rs
Outdated
Comment on lines
312
to
318
| ///let mut nav = Navigator::new(); | ||
| /// | ||
| ///nav.init(); | ||
| ///nav.pwm_enable(); | ||
| /// | ||
| ///nav.set_pwm_freq_prescale(99); // sets the pwm frequency to 60 Hz | ||
| ///nav.set_pwm_channel_value(PwmChannel::Ch0, 2048); // sets the duty cycle to 50% |
There was a problem hiding this comment.
It should have a space before the first character of each line of the doc comment
src/lib.rs
Outdated
Comment on lines
328
to
329
| /// Like [`set_pwm_channel_value`](struct.Navigator.html#method.set_pwm_channel_value). This function | ||
| /// sets the Duty Cycle on a list of multiple channels. |
There was a problem hiding this comment.
Maybe change the "on" to "for", meaning that the same value is applied to every channel of that list.
…nd *_channels_values)
RaulTrombin
force-pushed
the
channel_stantard
branch
from
0a3e34a
to
a40d85e
Compare
| @@ -310,6 +310,7 @@ impl Navigator { | |||
| /// use navigator_rs::{Navigator, PwmChannel}; | |||
| /// | |||
| /// let mut nav = Navigator::new(); | |||
| /// | |||
There was a problem hiding this comment.
Do not create commits based on PRs, create commits based on what they are doing.
There was a problem hiding this comment.
Besides that this is not fixing a PR, is fixing a commit in this PR.
RaulTrombin
force-pushed
the
channel_stantard
branch
from
a40d85e
to
747fe10
Compare
patrickelectric
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like we did on navigator-lib, channels should be called with Ch*,
As here:
*As pointed on Raom meeting, DiffChannels wasn't added to the navigator AdcChannel
Also add more documentation files for set_pwm_channel_value related functions.