Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index: Add overlay when user is not using chrome or edge #510

Merged
merged 1 commit into from
Oct 11, 2023
Merged

index: Add overlay when user is not using chrome or edge #510

merged 1 commit into from
Oct 11, 2023

Conversation

patrickelectric
Copy link
Member

fix #417

joaoantoniocardoso
joaoantoniocardoso reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Chromium and any other Chromium-based?

@patrickelectric
Copy link
Member Author

What about Chromium and any other Chromium-based?

From what I found it appears that Chromium it identifies itself as Chrome already.

@joaoantoniocardoso joaoantoniocardoso merged commit 9f14e19 into bluerobotics:master Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning when user is not using Chrome
2 participants
@patrickelectric @joaoantoniocardoso