Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenericIndicator mini-widget to display generic data #411

Merged

Conversation

rafaellehmkuhl
Copy link
Member

To start, it allows displaying data inside the genericVariables object, which is currently being populated by the NAMED_VALUE_FLOAT messages from Ardupilot.

image

Fix #410.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing fixup commit in the middle of the PR, also, canso we add a background over each icon to make it more clear there you can click or choose one of them, like a button background or something, to give a bit more of contrast.

@rafaellehmkuhl
Copy link
Member Author

There is a missing fixup commit in the middle of the PR, also, canso we add a background over each icon to make it more clear there you can click or choose one of them, like a button background or something, to give a bit more of contrast.

Will add some modification on hovering to tip on that.

@rafaellehmkuhl
Copy link
Member Author

There is a missing fixup commit in the middle of the PR, also, canso we add a background over each icon to make it more clear there you can click or choose one of them, like a button background or something, to give a bit more of contrast.

Added modified bg color on hover for clarification.

@patrickelectric patrickelectric merged commit 4cd3bd1 into bluerobotics:master Aug 9, 2023
5 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the add-value-named-floats branch August 10, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support displaying data from Ardupilot's NAMED_VALUE_FLOAT message
2 participants