New edit-mode #392
Merged
New edit-mode #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
requested review from
rjehangir,
patrickelectric,
Williangalvani,
joaoantoniocardoso and
ES-Alexander
rafaellehmkuhl
force-pushed
the
new-edit-mode
branch
5 times, most recently
from
b70d860
to
8f26d96
Compare
In the new layout, instead of opening a auto-hiding sidebar, we minify the main view to the top-right of the screen, while making the edit-menu fixed in the left and bottom edges. In the process, we changed the entire widget managing interface: - The available widgets now appear on the bottom, instead of in a dropdown list, making for easier access - One can now rearrange the widgets by dragging and dropping - One can now delete and make maximize/restore the widget by easily accessible buttons on the left bar - The widget-edit-menu was deprecated for the two above - One can select the active layer/view by just clicking on it on the list - One can now rename the layers/views easily Overall, the new interface is much more accessible and beautiful, and at the same time adds important new features. For now, managing profiles is deprecated, as their structure will be changed soon.
- Dragging now takes the widget-view size into account - Resizing can now be done from any widget corner, as well as the four edges - Grid snapping is deprecated temporaly
rafaellehmkuhl
force-pushed
the
new-edit-mode
branch
from
8f26d96
to
88fe7dc
Compare
rafaellehmkuhl
force-pushed
the
new-edit-mode
branch
from
88fe7dc
to
340f20c
Compare
rafaellehmkuhl
force-pushed
the
new-edit-mode
branch
from
340f20c
to
a593be7
Compare
patrickelectric
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete refactor of the edit-mode.
From our OKRs, this checks most of the requirements:
I believe the 3 remaining items are interesting for us to add before stable, as they change the profiles structure, but they can be done in a future PR, as the current changes already cover the majority of our user demands and vastly improve their experience using Cockpit.
new-edit-mode.mp4
Also fixes #233 and adds support for multiple simultaneous views with toggling.
To be merged after #398.
PR only lacking proper committing.