Improve joystick support for up to 32 axes and buttons #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
changed the title
ArturoManzoli
changed the title
|
Niiiiiiice! |
| @@ -1,14 +1,18 @@ | |||
| <template> | |||
| <div> | |||
| <div v-tooltip="tooltipText" class="relative cursor-pointer" :class="indicatorClass" @click="showDialog = true"> | |||
There was a problem hiding this comment.
Just to better get, what was breaking here? I tried reproducing but saw no bug.
There was a problem hiding this comment.
When the joystick config page was already open, showing this screen
And a joystick input was pressed, the whole config screen broke with a vNode error (dom injection incomplete).
The cause was the v-tooltip, when used as a prop, sometimes has bad collateral effects like this one. (Vuetify's fault).
(Running on master branch)
https://github.com/user-attachments/assets/2d4d11ce-c1b7-4e3b-939e-d1b11e0e8292
There was a problem hiding this comment.
Wow! I actually saw this one already, but had no idea the problem was the indicator! Nice catch!
rafaellehmkuhl
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshare.-.2024-10-02.9_37_53.AM.mp4
Closes #1208