Edit-menu: Modify interface from users feedback #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
requested changes
Sep 30, 2024
src/components/EditMenu.vue
Outdated
Comment on lines
871
to
887
| // Resize mini widgets so they fit the layout when the widget mode is set to mini widgets | ||
| const miniWidgetContainers = ref<Record<string, HTMLElement>>({}) | ||
| watch(widgetMode, () => { | ||
| if (widgetMode.value !== 'Mini widgets') return | ||
| nextTick(() => { | ||
| Object.values(miniWidgetContainers.value).forEach((element) => { | ||
| if (element.scrollWidth > element.clientWidth) { | ||
| let scale = 1 | ||
| while (element.scrollWidth > element.clientWidth) { | ||
| scale -= 0.01 | ||
| const actualElement = element.children[1] as HTMLElement | ||
| actualElement.style.scale = `${scale}` | ||
| } | ||
| } | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
I think you accidentally removed a feature here.
There was a problem hiding this comment.
Oops, Thanks for letting me know
ArturoManzoli
force-pushed
the
Fix-edit-mode-issues-from-feedback
branch
from
4731d35
to
a405dcd
Compare
|
There's just one thing that I remember @ES-Alexander mentioning that was not added here: the ability to click outside of the profile-select-menu and it closing. Can we also add that here? |
Done, @rafaellehmkuhl |
ArturoManzoli
force-pushed
the
Fix-edit-mode-issues-from-feedback
branch
from
a405dcd
to
0d47248
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
…-mode Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
Fix-edit-mode-issues-from-feedback
branch
from
0d47248
to
c3afe0e
Compare
rafaellehmkuhl
approved these changes
Oct 1, 2024
Yep, can merge! |
|
@ArturoManzoli I was using edit-mode and noticed the problem came back: 
Can you take a look? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @ES-Alexander feedback: