Add mapping table and hide svg mapping from unknown joystick models #1216
Conversation
ArturoManzoli
force-pushed
the
1131-hide-mapping-from-known-joystick-models
branch
from
42d3078
to
828da05
Compare
ArturoManzoli
changed the title
ArturoManzoli
force-pushed
the
1131-hide-mapping-from-known-joystick-models
branch
from
828da05
to
4476f4c
Compare
ArturoManzoli
force-pushed
the
1131-hide-mapping-from-known-joystick-models
branch
2 times, most recently
from
07e404c
to
3583063
Compare
There was a problem hiding this comment.
-
The remap section of the button mapping can be removed:
-
The shift/no-function keys should have dedicated buttons, instead of the protocol v-fors:
-
When the "Function mapping" section is opened, the "General" should close, and vice-versa.
-
There's something messing with the width, causing the view to overflow and open the horizontal scroll:
-
Clicking the "Boat functions mapping" button to change to another joystick profile is not making the SVG update (I think this is related to the removed line in the JoystickPS.vue file, because this only happens in the SVG, not the table):
-
As the joystick-profile selection, the profile-to-vehicle link and the regular/shift are all common to both modes, should them all be in the "General" section, and we change the other two to "Visual mode" and "Table mode"?
| @@ -31,18 +31,6 @@ | |||
| : 'lg:gap-y-3 xl:gap-y-4 gap-y-5 py-5' | |||
| " | |||
| > | |||
| <div | |||
There was a problem hiding this comment.
Could you change the message of this commit for something like "adjust main-menu icon alignments"?
| v-if="interfaceStore.mainMenuStyleTrigger === 'center-left'" | ||
| id="menu-trigger" | ||
| class="absolute right-0 top-[50%] -translate-y-[50%] flex items-center justify-center w-[30px] px-0 py-2 cursor-pointer overflow-hidden rounded-r-lg rounded-br-lg -ml-[1px]" | ||
| @click="toggleMainMenu" | ||
| > | ||
| <v-icon | ||
| class="text-white opacity-70" | ||
| :class="simplifiedMainMenu ? 'text-[30px] -mr-[14px]' : 'text-[40px] -mr-[8px]'" | ||
| >mdi-menu-left</v-icon | ||
| > | ||
| </div> | ||
| <GlassButton |
There was a problem hiding this comment.
Was this removed by mistake?
There was a problem hiding this comment.
Yes, it was removed based on a feedback by Rusty.
| @@ -40,7 +40,7 @@ module.exports = { | |||
| 'jsdoc/newline-after-description': 'off', | |||
| 'jsdoc/no-undefined-types': 'off', | |||
| 'jsdoc/require-returns': ['error', { forceReturnsWithAsync: false }], | |||
| 'max-len': ['error', { code: 120, ignoreUrls: true, ignoreComments: true }], | |||
There was a problem hiding this comment.
To follow the repository pattern it would be nice to reword this commit to something like "lint: Increase max line length to 180".
| @@ -206,7 +206,6 @@ watch( | |||
|
|
|||
| const joystickModel = toRefs(props).model | |||
| const buttonsActionsCorrespondency = toRefs(props).buttonsActionsCorrespondency | |||
| watch(buttonsActionsCorrespondency, () => updateLabelsState()) | |||
There was a problem hiding this comment.
This was removed by mistake right?
| class="w-[95%] flex-centered flex-column position-relative" | ||
| > | ||
| <p class="text-md font-semibold">{{ joystick.model }} controller</p> | ||
| <div v-if="currentJoystick?.model !== 'Unknown'"> |
There was a problem hiding this comment.
It would be nice to use the enum here: JoystickModel.Unknown, so we don't rely on the name, than can change at some point.
| onUnmounted(() => { | ||
| controllerStore.enableForwarding = true | ||
| }) | ||
|
|
There was a problem hiding this comment.
This should not be removed, otherwise the joystick won't work again after being configured.
| @@ -404,16 +641,13 @@ onMounted(async () => { | |||
| m2rSupportsExtendedManualControl.value = semver.gte(m2rVersion, '0.11.19') | |||
| const ardupilotVersion = await getArdupilotVersion(globalAddress) | |||
| ardupilotSupportsExtendedManualControl.value = semver.gte(ardupilotVersion, '4.1.2') | |||
| console.log('joystick', controllerStore.joysticks) | |||
ArturoManzoli
force-pushed
the
1131-hide-mapping-from-known-joystick-models
branch
from
3583063
to
ca540bc
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
1131-hide-mapping-from-known-joystick-models
branch
from
ca540bc
to
1e3edf7
Compare
Closes #1194
Closes #1131
Closes #970
Closes #1176