Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Refactored operators. (#532) #880

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactored operators. (#532) #880

wants to merge 1 commit into from

Conversation

ed728
Copy link
Contributor

@ed728 ed728 commented Feb 27, 2020

What this patch does to fix the issue.

Moves operators.py to base/operators.py and creates an __init__.py for the directory. In later PRs Operators will be gradually split into files.

Link to any relevant issues or pull requests.

This is the first is based on a previous PR(#642). That one is too large so it has been split, this is the first part. The other parts are mostly ready and will be made into PRs as soon as this one is done.

The next commits start factoring operators. The next are the branches below:
https://github.com/ed728/blueoil/tree/ops3
https://github.com/ed728/blueoil/tree/ops4
These will be made into PRs when this one has been merged.

Testing.

Manual and CI. Mainly to make sure imports in all modules don't break. Some Arm-related issues did come up but seems to be fine now.

@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@ed728 ed728 added the CI: auto-run Run CI automatically label Feb 27, 2020
@ed728 ed728 mentioned this pull request Feb 27, 2020
5 tasks
@ed728 ed728 added the CI: test-all Run all tests once label Feb 27, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Feb 27, 2020
@iizukak
Copy link
Member

iizukak commented Mar 2, 2020

@yd8534976
This PR try to solve your issue #532.
Can you check this PR is correct way to solve #532 ?

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@yd8534976
Copy link
Contributor

yd8534976 commented Mar 2, 2020

LGTM. Could you resolve conflicts? @ed728

@iizukak iizukak requested a review from tsawada March 2, 2020 23:55
# See the License for the specific language governing permissions and
# limitations under the License.
# =============================================================================
from .base import Operator, Conv, Pool, MaxPool, AveragePool, Add, Gemm, Mul,\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.python.org/dev/peps/pep-0008/#id19

The preferred way of wrapping long lines is by using Python's implied line continuation inside parentheses, brackets and braces. Long lines can be broken over multiple lines by wrapping expressions in parentheses. These should be used in preference to using a backslash for line continuation.

@yd8534976 yd8534976 removed their request for review March 17, 2020 02:29
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants