Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Create prototype of unit-test #1210

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Create prototype of unit-test #1210

wants to merge 11 commits into from

Conversation

lm-kajihara
Copy link
Contributor

@lm-kajihara lm-kajihara commented Sep 15, 2020 •
edited
Loading

Related to #743
Using googletest ([https://github.com/google/googletest]) and DownloadProject ([https://github.com/Crascit/DownloadProject])
All .cpp files in "tests/converter/unit-test/src" are unit test file of converter C++ runtime.
And all header files in "tests/converter/unit-test/include" are dummy of files in "blueoil/converter/templates/include".
This PR include only template function test.
(I forgot to remove pragma once in "tests/converter/unit-test/include")

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Sep 15, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lm-kajihara
Copy link
Contributor Author

change pop_count.h and CMakeLists.txt to use converter implementation
and remove "pramga once" in unit-test

primenumber
primenumber approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA for C++

@primenumber
Copy link
Contributor

@lm-kajihara is this PR still WIP ?

tsawada
tsawada reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what editor do you use? At your convenience, please update your editor config so that all text files end with a newline.

tests/converter/unit-test/CMakeLists.txt Outdated
include(third/DownloadProject/DownloadProject.cmake)
download_project(PROJ googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fetch master. Tests can break over time.
Use the tag consistent with mist/

@lm-kajihara lm-kajihara changed the title [WIP]create prototype of unit-test Create prototype of unit-test Oct 15, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@lm-kajihara
Copy link
Contributor Author

Remove "[WIP]" from this PR name.
I can't write more test because I don't know that expected bevavior of functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsawada tsawada tsawada left review comments

@primenumber primenumber primenumber approved these changes

@iizukak iizukak Awaiting requested review from iizukak

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lm-kajihara @CLAassistant @primenumber @tsawada