Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it work on ubuntu #63

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

Proxiweb
Copy link
Contributor

On Ubuntu variables aren't available in docker-compose.yml because docker expect an .env file in docker-compose.yml's folder.

@satran004
Copy link
Member

Thanks @Proxiweb . I tried version 0.9.1-beta with Ubuntu 24.04, and it seems to be working.

Could you please check your Docker version?

Distributor ID:	Ubuntu
Description:	Ubuntu 24.04 LTS
Release:	24.04
Codename:	noble

Docker version:

Docker version 27.1.2, build d01f264

I will try the changes in the PR and let you know.

@Proxiweb
Copy link
Contributor Author

My bad. I think the error is on my side. I was sure to have just installed docker on my fresh 24.04. So when I saw the same error message, I thought the docker version wasn't the source of the error. I've just tested on my dev computer, it's an old version (20.10).

Sorry for the time you spent on this :( , but I think the bash / sh error in the devkit.sh file is relevant ( it's the default sh & bash )

@satran004
Copy link
Member

@Proxiweb No worries. At least we know the root cause now.

Yes, we need the bash change.

Regarding the minimum Docker version, I think we should add it to doc. I have tested on Docker version 25.0.2 and later. Maybe we can set Docker 25.0.2 as the minimum version, or specify the version when the --env-file option was introduced.

We can also enhance devkit.sh to check the Docker version before startup

@satran004 satran004 self-requested a review August 21, 2024 03:47
@satran004 satran004 merged commit 6a883f5 into bloxbean:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants