Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Solid.js support #1886

Merged
merged 23 commits into from
Oct 25, 2023

Conversation

yisacc
Copy link
Contributor

@yisacc yisacc commented Aug 27, 2023

Description

Add solidJS support implemented solid package to enable solid reactivity when web3-onboard is used with in a solidjs codebase.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@socket-security
Copy link

socket-security bot commented Aug 27, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
vite 4.4.11 environment +23 211 MB vitebot
tsup-preset-solid 2.1.0 eval, filesystem +38 212 MB thetarnav.
tsup 7.2.0 eval, filesystem, environment +30 209 MB egoist
solid-devtools 0.27.7 None +17 3.04 MB thetarnav.
vite-plugin-solid 2.7.1 filesystem +37 214 MB ryansolid
solid-js 1.8.1 eval +2 3.37 MB ryansolid

@yisacc yisacc changed the title feat: add solidjs support Feat/add solidjs support Aug 27, 2023
@Adamj1232
Copy link
Member

Thanks for so much for the PR to add SolidJs support! Any chance you could add a small example here in our examples section?
If so I will get this tested and published along with getting a section added to our docs as well.
You can also remove the pnpm lock file when you have a moment.
Thanks again!

@Adamj1232
Copy link
Member

Adamj1232 commented Sep 5, 2023

@yisacc friendly ping on the above comments. It would be very helpful to have a SolidJS example to go along with this within the web3-onboard repo examples section.
There also seems to be some issues with the required node version for the new package causing build errors. Please see failing PR Status Checks below
Thanks!

@Adamj1232
Copy link
Member

@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment?

@yisacc
Copy link
Contributor Author

yisacc commented Sep 13, 2023

@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment?

sure I will update it

@yisacc
Copy link
Contributor Author

yisacc commented Oct 15, 2023

@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment?

@Adamj1232 please do review and merge it

@Adamj1232
Copy link
Member

@yisacc does solidjs require node version 18? The requirement in the package.json is causing issues with our build system as our minimum requirement is node v16

@Adamj1232
Copy link
Member

@yisacc I am still seeing the PR checks fail because of the node versioning. Please see https://github.com/blocknative/web3-onboard/actions/runs/6538139277/job/17753445603?pr=1886

@yisacc
Copy link
Contributor Author

yisacc commented Oct 16, 2023

@yisacc I am still seeing the PR checks fail because of the node versioning. Please see https://github.com/blocknative/web3-onboard/actions/runs/6538139277/job/17753445603?pr=1886

@Adamj1232 solved

@Adamj1232
Copy link
Member

@yisacc still seeing errors on the PR check

@yisacc
Copy link
Contributor Author

yisacc commented Oct 17, 2023

@yisacc still seeing errors on the PR check

@Adamj1232 i am working on it trying to solve the issues

@yisacc
Copy link
Contributor Author

yisacc commented Oct 17, 2023

@yisacc still seeing errors on the PR check

Now it's solved

@Adamj1232
Copy link
Member

Adamj1232 commented Oct 17, 2023

@yisacc thanks for that! I am doing some final testing and will add to our docs site.
Can you add an super simple example to the /examples/ within the repo with a connect btn?
If you can add this I can get this package out in the release today/tomorrow!
This is specifically helpful if webpack or some other bundler configs are required

@yisacc
Copy link
Contributor Author

yisacc commented Oct 17, 2023

@yisacc thanks for that! I am doing some final testing and will add to our docs site. Can you add an super simple example to the /examples/ within the repo with a connect btn? If you can add this I can get this package out in the release today/tomorrow! This is specifically helpful if webpack or some other bundler configs are required

@Adamj1232 i have added example

@Adamj1232 Adamj1232 merged commit 25fe93a into blocknative:develop Oct 25, 2023
2 checks passed
@Adamj1232 Adamj1232 changed the title Feat/add solidjs support Feat: Add Solid.js support Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants