Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arcana Auth SDK version #1860

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mmjee
Copy link
Contributor

@mmjee mmjee commented Aug 3, 2023

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally) (None)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected) (Not relevant)

  • [] send transaction
  • [] switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@mmjee mmjee mentioned this pull request Aug 3, 2023
20 tasks
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @arcana/[email protected]

@leightkt leightkt merged commit e851635 into blocknative:develop Aug 3, 2023
2 checks passed
leightkt added a commit that referenced this pull request Aug 3, 2023
@leightkt
Copy link
Contributor

leightkt commented Aug 3, 2023

@mmjee unfortunately this did not solve the issue- same error is popping up

@mmjee
Copy link
Contributor Author

mmjee commented Aug 3, 2023

@mmjee unfortunately this did not solve the issue- same error is popping up

We changed ArcanaProvider to extend SafeEventEmitter in the types (which implements once) in the latest 1.0.7 version. It also builds locally and all checks are good. Could there be some kind of caching-related issue?

leightkt added a commit that referenced this pull request Aug 3, 2023
* Arcana Auth SDK support (#1744)

* Fix: Aracana Config (#1857)

* add steps

* build staging steps

* update arcana package and yarn (#1858)

* update arcana package and yarn

* fix spacing in config

* try update spacing

* reset spacing on config

* update ci branch for test

* add ts-ignore

* reset config to develop

* add file extension to icon

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Update Arcana Auth SDK version (#1860)

* update arcana/demo packages and root version

* add ts-ignore for arcana

* Feat: Add native Base chain support and to all quickstarts (#1859)

* Add Base chain to all quickstarts

* Bump core package in demo

* update core, react, vue versions

---------

Co-authored-by: Adam Carpenter <[email protected]>
Co-authored-by: mmjee <[email protected]>
leightkt added a commit that referenced this pull request Aug 3, 2023
* Arcana Auth SDK support (#1744)

* Fix: Aracana Config (#1857)

* add steps

* build staging steps

* update arcana package and yarn (#1858)

* update arcana package and yarn

* fix spacing in config

* try update spacing

* reset spacing on config

* update ci branch for test

* add ts-ignore

* reset config to develop

* add file extension to icon

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Update Arcana Auth SDK version (#1860)

* update arcana/demo packages and root version

* add ts-ignore for arcana

* Feat: Add native Base chain support and to all quickstarts (#1859)

* Add Base chain to all quickstarts

* Bump core package in demo

* update core, react, vue versions

---------

Co-authored-by: Adam Carpenter <[email protected]>
Co-authored-by: mmjee <[email protected]>
Adamj1232 added a commit that referenced this pull request Aug 3, 2023
* Arcana Auth SDK support (#1744)

* Fix: Aracana Config (#1857)

* add steps

* build staging steps

* update arcana package and yarn (#1858)

* update arcana package and yarn

* fix spacing in config

* try update spacing

* reset spacing on config

* update ci branch for test

* add ts-ignore

* reset config to develop

* add file extension to icon

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Update Arcana Auth SDK version (#1860)

* Feat: Add native Base chain support and to all quickstarts (#1859)

* Add Base chain to all quickstarts

* Bump core package in demo

* Release 2.24.7 (develop) (#1863)

* update arcana/demo packages and root version

* add ts-ignore for arcana

* update core, react, vue versions

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Bump WC deps to the latest (#1866)

* Update docs for Base main (#1868)

---------

Co-authored-by: mmjee <[email protected]>
Co-authored-by: Kat Leight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants