Handing last couple items #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Apekshit Sharma <[email protected]>
Signed-off-by: Apekshit Sharma <[email protected]>
…mestamp Signed-off-by: Apekshit Sharma <[email protected]>
Keep all schema files together. Move to a better location in future. Add transaction_types table. Signed-off-by: Apekshit Sharma <[email protected]>
medvedev1088
approved these changes
May 23, 2020
scripts/create-tables.sh
Outdated
| ${BQ_TRANSACTION_TYPES_TABLE} \ | ||
| ${SCRIPT_DIR}/../hedera-etl-bigquery/src/main/resources/transaction-types-schema.json | ||
|
|
||
| # Not using 'bq load' or 'bq insert' because of lack of flag to specify project_id. That'd require operator to |
There was a problem hiding this comment.
--project_id is described in the global flags section https://cloud.google.com/bigquery/docs/reference/bq-cli-reference#bq_global_flags. I missed it at first too.
There was a problem hiding this comment.
ahh. removed the invalid comment.
Leaving query as is, no point spending time to change it.
Signed-off-by: Apekshit Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Which issue(s) this PR fixes:
Fixes #8
Fixes #16
Fixes #17
Special notes for your reviewer:
Diffs are nicely separated by commits. Was feeling lazy to send out 3 different PRs at 1:30am in night :)
Checklist