Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add menu click sounds from the game's menu. #907

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

agaertner
Copy link
Member

@agaertner agaertner commented Aug 20, 2023

Menu click sounds for the MenuItems.
1:1 like of the original menu of the game.

Not playing for checkable menu items.

The sounds will end up in many modules otherwise. Menus like the following would get a huge boost in feel.

image

Is this a breaking change?

No

@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dlamkins
Copy link
Member

dlamkins commented Dec 29, 2023

I like this. I see the files are added to both ref and content, though. I'm looking to slowly start reducing what we have in content and move it to the ref. Would it be possible to have them only in the ref?

@agaertner
Copy link
Member Author

I like this. I see the files are added to both ref and content, though. I'm looking to slowly start reducing what we have in content and move it to the ref. Would it be possible to have them only in the ref?

Sure. I will check.

Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 6%)

See analysis details on SonarCloud

@dlamkins dlamkins merged commit 0f17f0e into blish-hud:dev Apr 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants