delete source tar if transfer is successful only #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current script removes tar even if transfer failed. using rsync option we have possibility to remove source in case transfer is successful only. if failed we can transfer failed tars later.
|
We are using an almost identical patch since ages in production. I hope the PR gets merged at some point. |
farhatahmad
added a commit
that referenced
this pull request
Jun 27, 2024
* delete source tar if transfer is successful only current script removes tar even if transfer failed. using rsync option we have possibility to remove source in case transfer is successful only. if failed we can transfer failed tars later. * Update scalelite_post_publish.rb --------- Co-authored-by: Ahmad Farhat <[email protected]> Co-authored-by: Ahmad Farhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
current script removes tar even if transfer failed. using rsync option we have possibility to remove source in case transfer is successful only. if failed we can transfer failed tars later.
Testing Steps
make test record with disconnected shared storage or temporary disabled destination.
<meeting_id.tar> file should stay in work_dir: /var/bigbluebutton/recording/scalelite
if destination is available tar file is not present in work_dir: /var/bigbluebutton/recording/scalelite after transfer.