-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sections code for vector search #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
force-pushed
the
DVS
branch
5 times, most recently
from
August 9, 2023 09:49
e2e15bd
to
6538131
Compare
abhinavdangeti
requested changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to a lot of commentary here :)
* updating merge path with the ivf index creations * Fixes to API usage, etc. * bug fix: using the correct APIs to get ivf sub-index * Fix refactored API reference * Update go.mod to point to select versions - bleve_index_api, - scorch_segment_api, - go_faiss * Update GO VER and fix workflows --------- Co-authored-by: Thejas-bhat <[email protected]>
+ Also, in registerSegmentSection - forgot to unlock :D
abhinavdangeti
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faissVectorIndexSection
which maintains vector search related operations over a specific field - indexing a bunch of vectors and performing the similarity search on them.section
interface from section.go which basically ensures that the vector indexing related stuff that happens during the segment's lifecycle is agnostic of any other section that's present (for eg inverted index for textual data).