removing unnecessary atomic op on bytesWritten

blevesearch · Oct 25, 2024 · e85457c · e85457c
1 parent 5f8f0f0
commit e85457c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 12 deletions.
diff --git a/contentcoder.go b/contentcoder.go
@@ -19,7 +19,6 @@ import (
 	"encoding/binary"
 	"io"
 	"reflect"
-	"sync/atomic"
 
 	"github.com/golang/snappy"
 )
@@ -37,7 +36,7 @@ var (
 )
 
 type chunkedContentCoder struct {
-	bytesWritten uint64 // atomic access to this variable, moved to top to correct alignment issues on ARM, 386 and 32-bit MIPS.
+	bytesWritten uint64 // moved to top to correct alignment issues on ARM, 386 and 32-bit MIPS.
 
 	final     []byte
 	chunkSize uint64
@@ -112,11 +111,11 @@ func (c *chunkedContentCoder) Close() error {
 }
 
 func (c *chunkedContentCoder) incrementBytesWritten(val uint64) {
-	atomic.AddUint64(&c.bytesWritten, val)
+	c.bytesWritten += val
 }
 
 func (c *chunkedContentCoder) getBytesWritten() uint64 {
-	return atomic.LoadUint64(&c.bytesWritten)
+	return c.bytesWritten
 }
 
 func (c *chunkedContentCoder) flushContents() error {

diff --git a/docvalues.go b/docvalues.go
@@ -75,7 +75,6 @@ type docValueReader struct {
 	curChunkData   []byte // compressed data cache
 	uncompressed   []byte // temp buf for snappy decompression
 
-	// atomic access to this variable
 	bytesRead uint64
 }
 

diff --git a/intDecoder.go b/intDecoder.go
@@ -27,7 +27,6 @@ type chunkedIntDecoder struct {
 	data            []byte
 	r               *memUvarintReader
 
-	// atomic access to this variable
 	bytesRead uint64
 }
 

diff --git a/intcoder.go b/intcoder.go
@@ -18,7 +18,6 @@ import (
 	"bytes"
 	"encoding/binary"
 	"io"
-	"sync/atomic"
 )
 
 // We can safely use 0 to represent termNotEncoded since 0
@@ -36,7 +35,6 @@ type chunkedIntCoder struct {
 
 	buf []byte
 
-	// atomic access to this variable
 	bytesWritten uint64
 }
 
@@ -79,11 +77,11 @@ func (c *chunkedIntCoder) SetChunkSize(chunkSize uint64, maxDocNum uint64) {
 }
 
 func (c *chunkedIntCoder) incrementBytesWritten(val uint64) {
-	atomic.AddUint64(&c.bytesWritten, val)
+	c.bytesWritten += val
 }
 
 func (c *chunkedIntCoder) getBytesWritten() uint64 {
-	return atomic.LoadUint64(&c.bytesWritten)
+	return c.bytesWritten
 }
 
 // Add encodes the provided integers into the correct chunk for the provided

diff --git a/section_inverted_text_index.go b/section_inverted_text_index.go
@@ -398,11 +398,11 @@ func (i *invertedIndexOpaque) grabBuf(size int) []byte {
 }
 
 func (i *invertedIndexOpaque) incrementBytesWritten(bytes uint64) {
-	atomic.AddUint64(&i.bytesWritten, bytes)
+	i.bytesWritten += bytes
 }
 
 func (i *invertedIndexOpaque) BytesWritten() uint64 {
-	return atomic.LoadUint64(&i.bytesWritten)
+	return i.bytesWritten
 }
 
 func (i *invertedIndexOpaque) BytesRead() uint64 {