Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax for sqlalchemy-redshift CopyCommand #532

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mharradon
Copy link

I'm not sure why this line uses the keyword argument "table" - I can't find any docs, past or present, of CopyCommand using that syntax. This fixes an error I had when copying csv to redshift.

@necaris
Copy link
Contributor

necaris commented Jan 9, 2017

Note that it seems version 0.3 and earlier did use table. I don't see any reason why we should be tied to this old version, but we should either handle both argument names or explicitly require a particular version.

@mharradon
Copy link
Author

If we just use a positional argument instead of a keyword argument it should be backwards compatible.

Alternately if odo requires a sqlalchemy-redshift version that's 2 releases behind it should probably be in the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants