Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH CI size-diff by switching from make to meson #1972

Closed

Conversation

ALTracer
Copy link
Contributor

Detailed description

I wish there was a way to also report size-diff for 256-512 KiB probes with every driver compiled (and every applicable log statement compiled), but let's unblock the existing workflow first.
Tested on own fork by manulally triggering CI. Caveat: I asked for meson compile -C build-native bin the firmware bin alias, so it runs faster (omits BMDA), but still downloads hidapi/libusb/ftdi submodules for some reason. Network-isolated containers should not access internet past "install bdepends" and "fetch sources" stage (Gentoo ebuild FEATURE=network-sandbox).

Your checklist for this pull request

Closing issues

@dragonmux
Copy link
Member

The PR was much appreciated, however Esden finished the build system PR (#1967) which also fixes size-diff. We'll close this as its purpose has been served.

@dragonmux dragonmux closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants