Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for Ambiq Apollo 3 #1587

Conversation

sidprice
Copy link
Contributor

@sidprice sidprice commented Aug 2, 2023

This PR is a partial implementation of support for the Ambiq Apollo 3 Blue MCU. Due to the lack of documentation for flash erase and program, those features are not implemented.

Note: The MCU has a set of functions in a built-in ROM Bootloader that implement the required functions, however, there is no source code available or documentation describing how they should be used. In addition, implementing access to these functions for BMDA is complex.

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

@dragonmux dragonmux added the New Target New debug target label Aug 3, 2023
@dragonmux dragonmux changed the title Feature/add support for ambiq apollo 3 Feature: Support for Ambiq Apollo 3 Aug 3, 2023
@dragonmux dragonmux force-pushed the feature/add-support-for-ambiq-apollo-3 branch from e14d313 to 5aca03c Compare August 3, 2023 07:18
@dragonmux dragonmux added this to the v2.0 release milestone Oct 28, 2023
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 Sid, there are a few stylistic items that need addressing, but nothing terrible - once they're sorted we'll be happy to merge this as preliminary support.

Apologies this took so long to get reviewed. If you could rebase it against main and add an entry to the targets Meson build file for this family, that'd be fantastic.

src/target/target_probe.h Outdated Show resolved Hide resolved
src/target/apollo3.c Outdated Show resolved Hide resolved
src/target/apollo3.c Outdated Show resolved Hide resolved
src/target/apollo3.c Show resolved Hide resolved
src/target/apollo3.c Outdated Show resolved Hide resolved
src/target/apollo3.c Outdated Show resolved Hide resolved
litui added a commit to litui/blackmagic that referenced this pull request Sep 2, 2024
litui added a commit to litui/blackmagic that referenced this pull request Sep 2, 2024
@sidprice sidprice force-pushed the feature/add-support-for-ambiq-apollo-3 branch from 5aca03c to 6847180 Compare September 2, 2024 21:33
litui added a commit to litui/blackmagic that referenced this pull request Sep 2, 2024
@dragonmux
Copy link
Member

dragonmux commented Sep 2, 2024

LGTM, merging. Thank you both for the contribution!

@sidprice sidprice force-pushed the feature/add-support-for-ambiq-apollo-3 branch from 38b7fa7 to 93b690c Compare September 2, 2024 22:28
@dragonmux dragonmux merged commit 93b690c into blackmagic-debug:main Sep 2, 2024
26 checks passed
@sidprice sidprice deleted the feature/add-support-for-ambiq-apollo-3 branch September 4, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Target New debug target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants